Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed server physics when server has custom tickrate #515

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tyabus
Copy link

@tyabus tyabus commented May 19, 2021

No description provided.

@neico
Copy link
Contributor

neico commented Jun 27, 2021

Shouldn't the client tickrate also be adjusted?
Otherwise it would desync?

https://github.com/ValveSoftware/source-sdk-2013/blob/master/mp/src/game/client/physics.cpp#L180

-physenv->SetSimulationTimestep( IsXbox() ? DEFAULT_XBOX_CLIENT_VPHYSICS_TICK : DEFAULT_TICK_INTERVAL );
+physenv->SetSimulationTimestep( IsXbox() ? DEFAULT_XBOX_CLIENT_VPHYSICS_TICK : gpGlobals->interval_per_tick );

@tyabus
Copy link
Author

tyabus commented Jun 29, 2021

Shouldn't the client tickrate also be adjusted?
Otherwise it would desync?

https://github.com/ValveSoftware/source-sdk-2013/blob/master/mp/src/game/client/physics.cpp#L180

-physenv->SetSimulationTimestep( IsXbox() ? DEFAULT_XBOX_CLIENT_VPHYSICS_TICK : DEFAULT_TICK_INTERVAL );
+physenv->SetSimulationTimestep( IsXbox() ? DEFAULT_XBOX_CLIENT_VPHYSICS_TICK : gpGlobals->interval_per_tick );

I've ran hl2dm server at 44 tickrate with this like for a year, and i didn't noticed any strange behavior on client.

@tyabus tyabus force-pushed the custom-tickrate-physics-fix branch from 75f6986 to 7091e9b Compare August 15, 2021 18:21
XutaxKamay pushed a commit to XutaxKamay/css_enhanced that referenced this pull request Aug 27, 2024
Baklojan added a commit to Baklojan/source-2013 that referenced this pull request Dec 21, 2024
-Fixed npc_manhack not notifying npc_template_maker/npc_maker when thrown and destroyed with gravity gun
ValveSoftware/source-sdk-2013#362

-Fixed server physics when server has custom tickrate
ValveSoftware/source-sdk-2013#515

-Fixed infinite recursion by using incorrect key on value conversation
ValveSoftware/source-sdk-2013#380

-Fix dereferencing null if m_iActiveSound is no longer valid index by save restore
ValveSoftware/source-sdk-2013#381

-Fix Linux soundscapes
ValveSoftware/source-sdk-2013#448

-Fix typo in logical expression
ValveSoftware/source-sdk-2013#502
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants