Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdf2json: fix stdin/stdout for large inputs (TypeError: can't concat str to bytes) #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markus-wa
Copy link

not sure if this works for all python versions, but I had to do this to avoid a TypeError: can't concat str to bytes

$ cat csgo_english.txt.gz | gunzip | vdf2json > /dev/null
Traceback (most recent call last):
  File "/home/mark/.local/bin/vdf2json", line 8, in <module>
    sys.exit(main())
  File "/home/mark/.local/lib/python3.8/site-packages/vdf2json/cli.py", line 39, in main
    data = vdf.loads(args.infile.read(), mapper=OrderedDict)
  File "/usr/lib/python3.8/codecs.py", line 500, in read
    data = self.bytebuffer + newdata
TypeError: can't concat str to bytes

after the fix this works

$ cat csgo_english.txt.gz | gunzip | python3 vdf2json/vdf2json/cli.py > /dev/null
// all ok, no error

@markus-wa
Copy link
Author

friendly ping to @rossengeorgiev 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant