Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ItemEntity affected by Create's AirCurrent cannot be pick by Create Funnels, Fix #867, #688 #955

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix ItemEntity affected by Create's AirCurrent cannot be pick by Create Funnels, Fix #867, #688 #955

merged 1 commit into from
Sep 23, 2024

Conversation

MoePus
Copy link
Contributor

@MoePus MoePus commented Sep 4, 2024

Create's Funnels are using entityInside to pick up items,
but Entity::tryCheckInsideBlocks is skipped by vs2's mixin

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thetheaplant thetheaplant mentioned this pull request Sep 18, 2024
Closed
1 task
@ewoudje
Copy link
Contributor

ewoudje commented Sep 20, 2024

Yep nice catch, Im kinda worried if we the mixin also skips other things such as checking for fire, or popping the profiler.

@Rubydesic
Copy link
Contributor

lgtm

@Rubydesic Rubydesic merged commit be13687 into ValkyrienSkies:1.18.x/main Sep 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewoudje ewoudje ewoudje approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MoePus @CLAassistant @ewoudje @Rubydesic