when you log off on a ship and it moves, you should log on still in the ship, not in the middle of nowhere #486
Labels
Comments
Rubydesic
added
enhancement
|
Hello! I've tried my own hand at implementing this, if no one else has yet. Excuse any bad coding practices or formatting that doesn't align with the styleguide. I'm a bit shy to open a PR because I want to make sure that everything is alright first, but anyway, here it is: https://github.com/m-doescode/Valkyrien-Skies-2-fork/tree/1.20.1/feature/teleport-reconnected-players |
|
Of course there are still currently some redundant print statements that I'll clean up if this solution is accepted, but this is what I have so far. |
|
There is already a similar mod Valkyrien Relogs. |
|
Thanks! Should I open a PR for the fix? |
|
Absolutely. |
ewoudje
pushed a commit
that referenced
this issue
Aug 15, 2024
… still in the ship, not in the middle of nowhere (#937) * Added basic implementation of teleporting disconnected players back onto ships * Removed print statements * Extracted MAX_ONBOARD_TICKS from magic number * Moved MAX_ONBOARD_TICKS to a config option, and added the ability for reconnected player teleportation to be disabled --------- Authored-by: m-doescode <[email protected]>
xiewuzhiying
pushed a commit
to xiewuzhiying/Valkyrien-Skies-2
that referenced
this issue
Aug 28, 2024
… should log on still in the ship, not in the middle of nowhere (ValkyrienSkies#937) * Added basic implementation of teleporting disconnected players back onto ships * Removed print statements * Extracted MAX_ONBOARD_TICKS from magic number * Moved MAX_ONBOARD_TICKS to a config option, and added the ability for reconnected player teleportation to be disabled --------- Authored-by: m-doescode <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: