For issue mozilla-mobile#10727 - Hide saved logins details

Removed the clearFlags call from the HomeActivity that was causing this issue and removed the now redundant call to update the flag from the redirectToReAuth method
ValentinTimisica · Jun 22, 2020 · eb45b37 · eb45b37
1 parent e9bb11e
commit eb45b37
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/app/src/main/java/org/mozilla/fenix/HomeActivity.kt b/app/src/main/java/org/mozilla/fenix/HomeActivity.kt
@@ -196,8 +196,6 @@ open class HomeActivity : LocaleAwareAppCompatActivity() {
     final override fun onPause() {
         if (settings().lastKnownMode.isPrivate) {
             window.addFlags(WindowManager.LayoutParams.FLAG_SECURE)
-        } else {
-            window.clearFlags(WindowManager.LayoutParams.FLAG_SECURE)
         }
         super.onPause()
 

diff --git a/app/src/main/java/org/mozilla/fenix/ext/Fragment.kt b/app/src/main/java/org/mozilla/fenix/ext/Fragment.kt
@@ -57,14 +57,12 @@ fun Fragment.hideToolbar() {
 /**
  * Pops the backstack to force users to re-auth if they put the app in the background and return to it
  * while being inside the saved logins flow
- * It also updates the FLAG_SECURE status for the activity's window
  *
  * Does nothing if the user is currently navigating to any of the [destinations] given as a parameter
  *
  */
 fun Fragment.redirectToReAuth(destinations: List<Int>, currentDestination: Int?) {
     if (currentDestination !in destinations) {
-        activity?.let { it.checkAndUpdateScreenshotPermission(it.settings()) }
         findNavController().popBackStack(R.id.savedLoginsAuthFragment, false)
     }
 }