Skip to content

Commit

Permalink
update(kserve): manifests path from in-repo (opendatahub-io#657)
Browse files Browse the repository at this point in the history
* update(kserve): manifests path from in-repo
* update: no more odh-manifests in ODH build

Signed-off-by: Wen Zhou <[email protected]>
  • Loading branch information
zdtsw authored Oct 30, 2023
1 parent e5bc958 commit 890da22
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 11 deletions.
4 changes: 2 additions & 2 deletions components/kserve/kserve.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import (

var (
ComponentName = "kserve"
Path = deploy.DefaultManifestPath + "/" + ComponentName + "/base"
Path = deploy.DefaultManifestPath + "/" + ComponentName + "/overlays/odh"
DependentComponentName = "odh-model-controller"
DependentPath = deploy.DefaultManifestPath + "/" + DependentComponentName + "/base"
ServiceMeshOperator = "servicemeshoperator"
Expand Down Expand Up @@ -53,7 +53,7 @@ func (k *Kserve) OverrideManifests(_ string) error {
return err
}
// If overlay is defined, update paths
defaultKustomizePath := "base"
defaultKustomizePath := "overlays/odh"
if subcomponent.SourcePath != "" {
defaultKustomizePath = subcomponent.SourcePath
}
Expand Down
12 changes: 3 additions & 9 deletions get_all_manifests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ MANIFEST_RELEASE="master"
MANIFESTS_TARBALL_URL="${GITHUB_URL}/${MANIFEST_ORG}/odh-manifests/tarball/${MANIFEST_RELEASE}"

# component: dsp, kserve, dashbaord, cf/ray. in the format of "repo-org:repo-name:branch-name:source-folder:target-folder"
# TODO: workbench, modelmesh, monitoring, etc
# TODO: odh-mm-monitoring, etc
declare -A COMPONENT_MANIFESTS=(
["codeflare"]="opendatahub-io:codeflare-operator:main:config:codeflare"
["ray"]="opendatahub-io:kuberay:master:ray-operator/config:ray"
Expand All @@ -21,6 +21,7 @@ declare -A COMPONENT_MANIFESTS=(
["trustyai"]="trustyai-explainability:trustyai-service-operator:release/1.10.2:config:trustyai-service-operator"
["model-mesh"]="opendatahub-io:modelmesh-serving:release-0.11.0:config:model-mesh"
["odh-model-controller"]="opendatahub-io:odh-model-controller:release-0.11.0:config:odh-model-controller"
["kserve"]="opendatahub-io:kserve:release-v0.11.0:config:kserve"
)

# Allow overwriting repo using flags component=repo
Expand All @@ -47,14 +48,7 @@ if [ "$#" -ge 1 ]; then
done
fi

# pre-cleanup local env
rm -fr ./odh-manifests/* ./.odh-manifests-tmp/

mkdir -p ./.odh-manifests-tmp/ ./odh-manifests/
wget -q -c ${MANIFESTS_TARBALL_URL} -O - | tar -zxv -C ./.odh-manifests-tmp/ --strip-components 1 > /dev/null
cp -r ./.odh-manifests-tmp/modelmesh-monitoring/ ./odh-manifests
cp -r ./.odh-manifests-tmp/kserve/ ./odh-manifests
rm -rf ${MANIFEST_RELEASE}.tar.gz ./.odh-manifests-tmp/
# R.I.P, odh-manifests

for key in "${!COMPONENT_MANIFESTS[@]}"; do
echo "Cloning repo ${key}: ${COMPONENT_MANIFESTS[$key]}"
Expand Down

0 comments on commit 890da22

Please sign in to comment.