Skip to content

Commit

Permalink
fix(lint): disables deprecated linters (opendatahub-io#1068)
Browse files Browse the repository at this point in the history
Removes linters which are not maintained anymore and deprecated. Most
has been replaced with `unused` linter which is enabled by default.

(cherry picked from commit 8e0998f)
  • Loading branch information
bartoszmajsak authored and VaishnaviHire committed Jul 24, 2024
1 parent 5ca009a commit 65a5d49
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,18 +56,25 @@ linters:
enable-all: true
disable:
- containedctx # detects struct contained context.Context field
- deadcode # deprecated
- depguard # [replaced by gomodguard] checks if package imports are in a list of acceptable packages
- exhaustruct # Prevents empty struct. We use a lot of these so I think it is safe to disable.c
- forbidigo
- gochecknoglobals # Prevents use of global vars.
- gofumpt
- golint # deprecated
- gomnd # Doesnot allow hardcoded numbers
- gomoddirectives # Doesnot allow replace in go mod file
- mnd
- ifshort # deprecated
- interfacer
- maligned # deprecated
- nestif
- nilnil
- paralleltest # [too many false positives] detects missing usage of t.Parallel() method in your Go test
- scopelint # deprecated
- structcheck # deprecated
- tagliatelle
- varcheck # deprecated
- varnamelen # doesnot allow shorter names like c,k etc. But golang prefers short named vars.
- wsl # [too strict and mostly code is not more readable] whitespace linter forces you to use empty lines
- wrapcheck # check if this is required. Prevents direct return of err.
Expand Down

0 comments on commit 65a5d49

Please sign in to comment.