-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated ghdl_interface.py per #458 #459
Conversation
Another thing to note is that |
As you mentioned it would be good if the name conveyed that gtkwave was involved. Maybe calling the sim_option ghdl.gtkwave_script would be better. Also the sim option should be mentioned in the documentation. The source for the documentation is within ui.py where there is a list of sim options in a docstring. Just adding the new option there with a small description is enough. |
…th changing sim option to be more obvious about how GTK is involved
vunit/ui.py
Outdated
``ghdl.gtkwave_script.gui`` | ||
A user defined TCL-file that is sourced after the design has been loaded in the GUI. | ||
For example this can be used to configure the waveform viewer. | ||
During script evaluation the ``vunit_tb_path`` variable is defined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see how vunit_tb_path tcl variable is available so this documentation is inaccurate. Maybe copy paste error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, sorry about that
During script evaluation the ``vunit_tb_path`` variable is defined |
I tried adding
However, if I replace https://github.com/VUnit/vunit/blob/master/vunit/ghdl_interface.py#L276 with @GlenNicholls, might those additional double quotes be platform-dependent? |
This update allows a TCL script to be passed to GTKWave when the
-g
flag is passed if the environment has theset_sim_option('ghdl.init_file.gui', '<fileName>.tcl')
set. The limitation is that only a single file can be passed, however<fileName>.tcl
can source other TCL scripts if desired.