Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add axi master #1017

Open
wants to merge 56 commits into
base: master
Choose a base branch
from
Open

Add axi master #1017

wants to merge 56 commits into from
+2,635 −0

Conversation

DavidMartinPhios
Copy link

Added axi master with equally powerful implementation as axi lite master has

@DavidMartinPhios DavidMartinPhios changed the title AXI master Add axi master May 13, 2024
@DavidMartinPhios DavidMartinPhios marked this pull request as ready for review May 15, 2024 12:33
@LarsAsplund
Copy link
Collaborator

Thanks for getting this started. I'm aware of several implementations over the years but non of them made it to open source. It so happens that I have my eyes on yet another implementation in progress that may or not make it to the public. Even if that doesn't become open source, I can keep track of what features it requires such that the VC released by VUnit can meet those as well.

I will get back when I have more info.

@DavidMartinPhios
Copy link
Author

Thanks for getting this started. I'm aware of several implementations over the years but non of them made it to open source. It so happens that I have my eyes on yet another implementation in progress that may or not make it to the public. Even if that doesn't become open source, I can keep track of what features it requires such that the VC released by VUnit can meet those as well.

I will get back when I have more info.

As you might figured out already this implementation is not yet finished. I am still working on it. Basically I am now adding the functionallity to each single signal. At the moment I have deticated reserved time to implement this specific VC. It would be nice to know if the work will get obsolete some day or be replaced by another implementation. Otherwise I will keep going with the implementation. Hopefully with your early review / support.

@LarsAsplund
Do you think that it is necessary to move the signals id, last, etc. to the bus_master record or is it ok to implement them around on a higher level as it is right now?

@LarsAsplund
Copy link
Collaborator

Since you've started and the other implementation may not make it to open source, I think we should continue on what you have. What I hope is to align on the required feature set such that you both can work on the open implementation in the end. I will come back and review a bit later,

@DavidMartinPhios
Copy link
Author

Since you've started and the other implementation may not make it to open source, I think we should continue on what you have. What I hope is to align on the required feature set such that you both can work on the open implementation in the end. I will come back and review a bit later,

Thank you for the answer! I am currently working on the read burst behaviour. It is not finished yet but I think you could get an idea where the journey should go.

@DavidMartinPhios
Copy link
Author

@LarsAsplund
Do you already had the change to review the axi master? At the moment a very basic version is implemented but it should provide basic read and write possibilities for burst and none burst.

@LarsAsplund
Copy link
Collaborator

I have yet to review it. The other implementation I'm keeping my eyes on is settling now so I think I will be in a position to review shortly and then make sure that the one you have is "feature compatible". With that I don't mean that it has to have all features but rather that the API is such that it can evolve and eventually cover all the things the other project is requiring. That way there is a chance that the two efforts can be merged in the end.

@DavidMartinPhios
Copy link
Author

I have yet to review it. The other implementation I'm keeping my eyes on is settling now so I think I will be in a position to review shortly and then make sure that the one you have is "feature compatible". With that I don't mean that it has to have all features but rather that the API is such that it can evolve and eventually cover all the things the other project is requiring. That way there is a chance that the two efforts can be merged in the end.

@LarsAsplund
I will wait for your review before I continue further implementations. Just to be sure that it is not completely running in the wrong direction.

LarsAsplund and others added 25 commits November 4, 2024 16:09
@LarsAsplund
Added rule for locking
0e7eabe
@LarsAsplund
Various updates to the rules.
4dd66f0
@LarsAsplund
Add support package for VCs.
d3bf541
@c-thaler
initial checkin of APB master and slave VC
4448cb5
@c-thaler
set expected word for single write test
efb0849
@c-thaler
implement wait states
d15414c
@c-thaler
fix trailing whitespace
60ce019
@c-thaler
fix another trailing whitespace
49f5c3c
@c-thaler
use single generic parameter
86cb9e8 
All generics are now integrated into a single parameter of type
apb_master_t.
@c-thaler
reduce to single generic parameter in apb slave
a658da4
@c-thaler
use null_actor/null_logger as defaults for master
e3c1ec3
@c-thaler
use null_logger as default for apb slave
a69abfe
@c-thaler
let the apb_master ctor be handled by bus_master
839edf0 
The bus_master implementation will create an actor if null_actor is
given as parameter. So we don't have to do it in apb_master.
@c-thaler
lock test_runner_cleanup entry gate
043ba5e 
Keep it locked while there is unfinished work to do.
@c-thaler
add support for sync interface
e7005bc
@c-thaler
fix whitespace issues
bf15f57
@c-thaler
rename APB files according to specification
8d84a03
@c-thaler
rename entities according to spec
b156f16
@c-thaler
implement support for pslverror
e44e313 
Major change to support optional pslverror signal of APB3.
@c-thaler
add pslverror test cases and fix issue
b1a7968
@c-thaler
fix instance names
f6fd6e5
@c-thaler
add id and unexpected message policy parameter
2eb5409 
Implementing rules 5 and 10.
The logger name is set according to the id field.
@DavidMartinPhios
Merge branch 'VUnit:master' into master
94a43c9
@DavidMartinPhios
Added id to verification component - rule 4
b893ec2
@DavidMartinPhios
Added id also to logger - rule 5
07f2f9f
@DavidMartinPhios
Copy link
Author

@LarsAsplund What is the sync interface mentioned by rule 9? Do I have to make some changes to my entity? If yes, could you please give me more information about what I have to change / implement?

@DavidMartinPhios
Copy link
Author

@LarsAsplund Rule 9 and 11 are still not implemented. Do you have any examples or suggestions of what I have to implement there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidMartinPhios @LarsAsplund @c-thaler