Skip to content

Commit

Permalink
Bumped OSVVM to 2024.07. Solves #1046.
Browse files Browse the repository at this point in the history
InitSeed changed behavior such that randomized testbenches don't reproduce the previously
used stimuli. One testbench had to be updated to compensate.
  • Loading branch information
LarsAsplund committed Aug 8, 2024
1 parent 84ac0f5 commit f8a1e09
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 5 deletions.
5 changes: 5 additions & 0 deletions docs/news.d/1046.breaking.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bumped OSVVM to 2024.07.

The seed generation of OSVVM has changed to a new algorithm which may cause some testbenches using InitSeed(some_value)
to fail since the random sequence of values doesn't reproduce what was previously generated. This can occur if the testbench
has assumptions on the random sequence that aren't explicitly enforced (other than setting the seed).
12 changes: 9 additions & 3 deletions vunit/builtins.py
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def _add_osvvm(self):
Add osvvm library
"""
library = self._add_library_if_not_exist(
"osvvm", "Library 'OSVVM' previously defined. Skipping addition of builtin OSVVM (2023.04)."
"osvvm", "Library 'OSVVM' previously defined. Skipping addition of builtin OSVVM."
)
if library is None:
return
Expand All @@ -163,10 +163,10 @@ def _add_osvvm(self):
in your VUnit Git repository? You have to do this first if installing using setup.py."""
)

for file_name in glob(str(VHDL_PATH / "osvvm" / "*.vhd")):
for file_name in glob(str(VHDL_PATH / "osvvm" / "*.vhd")) + glob(str(VHDL_PATH / "osvvm" / "deprecated" / "*.vhd")):
bname = Path(file_name).name

if (bname == "AlertLogPkg_body_BVUL.vhd") or ("2019" in bname):
if bname in ["LanguageSupport2019Pkg.vhd", "MessagePkg.vhd", "ClockResetPkg_2024_05.vhd", "MemoryGenericPkg_xilinx.vhd"]:
continue

if ((simulator_coverage_api != "rivierapro") and (bname == "VendorCovApiPkg_Aldec.vhd")) or (
Expand All @@ -180,6 +180,9 @@ def _add_osvvm(self):
"ScoreboardGenericPkg.vhd",
"ScoreboardPkg_int.vhd",
"ScoreboardPkg_slv.vhd",
"ScoreboardPkg_signed.vhd",
"ScoreboardPkg_unsigned.vhd",
"ScoreboardPkg_IntV.vhd",
"MemoryPkg.vhd",
"MemoryGenericPkg.vhd",
]
Expand All @@ -191,6 +194,9 @@ def _add_osvvm(self):
in [
"ScoreboardPkg_int_c.vhd",
"ScoreboardPkg_slv_c.vhd",
"ScoreboardPkg_signed_c.vhd",
"ScoreboardPkg_unsigned_c.vhd",
"ScoreboardPkg_IntV_c.vhd",
"MemoryPkg_c.vhd",
"MemoryPkg_orig_c.vhd",
]
Expand Down
2 changes: 1 addition & 1 deletion vunit/vhdl/osvvm
Submodule osvvm updated 47 files
+5 −0 .gitignore
+21 −5 AUTHORS.md
+1,319 −323 AlertLogPkg.vhd
+407 −190 CHANGELOG.md
+0 −44 CONTRIBUTORS.md
+377 −0 ClockResetPkg.vhd
+381 −168 CoveragePkg.vhd
+807 −0 DelayCoveragePkg.vhd
+125 −0 IfElsePkg.vhd
+64 −0 LanguageSupport2019Pkg.vhd
+91 −0 LanguageSupport2019Pkg_c.vhd
+99 −26 MemoryGenericPkg.vhd
+1 −0 MemoryPkg.vhd
+1 −0 MemorySupportPkg.vhd
+3 −1 NamePkg.vhd
+26 −3 NameStorePkg.vhd
+5 −0 OsvvmContext.vhd
+337 −337 OsvvmGlobalPkg.vhd
+7 −4 OsvvmScriptSettingsPkg.vhd
+9 −5 OsvvmScriptSettingsPkg_default.vhd
+169 −0 OsvvmSettingsPkg.vhd
+172 −0 OsvvmSettingsPkg_default.vhd
+3 −4 README.md
+20 −1 RandomBasePkg.vhd
+34 −27 RandomPkg.vhd
+78 −20 ReportPkg.vhd
+94 −46 ResizePkg.vhd
+194 −77 ScoreboardGenericPkg.vhd
+58 −0 ScoreboardPkg_IntV.vhd
+54 −0 ScoreboardPkg_signed.vhd
+3 −5 ScoreboardPkg_slv.vhd
+54 −0 ScoreboardPkg_unsigned.vhd
+166 −299 TbUtilPkg.vhd
+80 −22 TextUtilPkg.vhd
+1 −0 TranscriptPkg.vhd
+1 −1 VendorCovApiPkg.vhd
+2 −2 VendorCovApiPkg_Aldec.vhd
+233 −0 deprecated/ClockResetPkg_2024_05.vhd
+273 −143 deprecated/MemoryGenericPkg_xilinx.vhd
+297 −148 deprecated/MemoryPkg_c.vhd
+1,592 −0 deprecated/MemoryPkg_orig_c.vhd
+3,518 −0 deprecated/ScoreboardPkg_IntV_c.vhd
+224 −136 deprecated/ScoreboardPkg_int_c.vhd
+3,517 −0 deprecated/ScoreboardPkg_signed_c.vhd
+228 −140 deprecated/ScoreboardPkg_slv_c.vhd
+3,517 −0 deprecated/ScoreboardPkg_unsigned_c.vhd
+90 −17 osvvm.pro
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ begin
check_expected_was_written(buf);
end loop;

assert num_ops > 5000;
assert num_ops > 4500;

elsif run("Test that permissions are checked") then
-- Also check that memory errors are made to the axi slave logger
Expand Down

0 comments on commit f8a1e09

Please sign in to comment.