Skip to content

Commit

Permalink
Added comment about revisiting after dotnet#5857 is fixed
Browse files Browse the repository at this point in the history
  • Loading branch information
VSadov committed Mar 4, 2020
1 parent f412beb commit 00a91b8
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/coreclr/src/vm/ecall.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,9 @@ void ECall::PopulateManagedCastHelpers()
// so indirection is not as big concern.
// We JIT-compile the following helpers eagerly here to avoid indirection costs.

//TODO: revise if this specialcasing is still needed when crossgen supports tailcall optimizations
// see: https://github.com/dotnet/runtime/issues/5857

pMD = MscorlibBinder::GetMethod((BinderMethodID)(METHOD__CASTHELPERS__STELEMREF));
pMD->DoPrestub(NULL);
// This helper is marked AggressiveOptimization and its native code is in its final form.
Expand Down

0 comments on commit 00a91b8

Please sign in to comment.