-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename VSCodium to Codium #293
base: master
Are you sure you want to change the base?
Conversation
I think this PR takes it a bit too far; the settings/config folders were fresh, so when I downloaded + installed Codium from my branch, it had none of my modified settings / keymaps. I am on a Mac, so this is because On the other hand, Visual Studio Code uses |
Adding a note about the change/where to move settings on the releases page should suffice. And honestly, if someone went through all the effort to install VSCodium instead of VSCode, they should be able to handle moving settings over 🙂 |
👋 wanted to check in here - is there something I could help out with? |
Sorry for the huge delay on this everyone. I don't have much time for VSCodium work these days. This PR can be merged after conflicts are resolved and after I (or anyone) has done some additional testing around the auto-update experience. Specifically I'm wondering what happens if the next release is cut as Codium; do users with autoupdate enabled (such as myself) automatically download + install it? If so, my suspicion is we'll see a dozen new issues logged because "after update all my settings/themes disappeared" (despite any notes we may put on the Releases page). I'd rather think through some ways to avoid that disruption if possible. If there's no way around it, I'll opt for clear documentation around what to do (copy settings/themes to new dir) and noisy messaging on the Releases page and README. |
Instead of putting any note/Instruction anywhere, will it not be better to show a data migration progress and move the data from old directories(if found) to new ones or rename the old ones? |
@stripedpajamas any news on this PR? |
Any plan on moving this forward? |
Conflicts needs to be fixed. As @stripedpajamas doesn't have time to invest in this anymore, maybe it would be better to create another PR with people willing to fix this? |
@stripedpajamas Do you want me to make the changes? |
@daiyam since this is a big disruptive change, I think it would be better to first introduce a way for non-Github-users to be notified of "big disruptive changes", e.g. #599 . My idea is that if we sideload VSCodium changelogs into the existing release notes from MS, we could make this change and provide the notification + workarounds / next steps to the users that way. Thoughts ? |
@stripedpajamas I agree 100%. To customize the welcome page is a good idea. |
We can also add a modal (with |
I think wherever something is named "vscode" we can leave ours as "vscodium" (are there any such examples?), and wherever something is named "code" we will have "codium" (e.g. snapcraft, the local binary). For places where Microsoft's name is "visual studio code", I'm not sure what ours should be, e.g. brew: https://formulae.brew.sh/cask/visual-studio-code, but I would lean towards Also I think the RPM/DEB part is already done (at least the README is instructing to install |
No discussion here, I just want to say I totally agree with:
|
... still? |
@daiyam Can you work on automated adjusting of the welcome page and the option to one-time raise an information on update? This would allow to "get the news out". I suggest to postpone the actual name change to a specific version up-front which is not "too short" so people have a chance to see it even when they don't open VSCodium/update it very regularly. Maybe specifying "executable name will be changed to codium in version 1.68 (and then push the changes on current master again to have it ready) until 1.67, so we're quite sure that 1.68 should have no issue (or all that one main version before/later). |
@GitMensch I think it's too late. The project is very well known to change his name. It feels like renaming 'ABBA' to 'BBA'.
Done. |
I'm not sure about "too late" actually and am in favor of dropping the "VS" prefix. We may could also use the (currently not available) adjusted welcome page and extra info message to point to a new survey to receive user feedback - without such information to the users it doesn't make any sense to create a survey issue again.
Ah, that's true for any environment but Win32 I guess (there are codium and codium.bat under "bin", but the executable is still named VSCodium.exe) - if this is only different on Win32 then I definitely would suggest to adjust that. |
I am in favor of renaming the app to codium |
When GitHub announced they're killing off Atom I started looking into VSCode and found this project instead. When can this change be implemented? 😇 From what I've read here there doesn't really seem to be any reason not to do it? As a new user I was confused why it was named Visual Studio Codium. |
I also agree with changing the name, and I want to add another point, "VS" meaning "Visual Studio" is, from what I can tell, a trademark of Microsoft. So even more reason to distance from that convention. |
@ioquatix I agree. "VSCodium" has probably the VS trademarked by MS. |
This is an inactive PR, therefore it's not really news now. |
but |
@stripedpajamas @thisiskeithb @janniks @guruathwal @LRNZ09 I have made a fork, which has four differences from here.
https://github.com/Alex313031/codium I make builds for Linux and Windows |
Please make separate PRs for 1, 2 and 4 and outline a bit more in the README where the differences are (I suggest to do this relative at the top). |
I don't think 1 isn't necessary since it's his fork name. Personally, while we don't have any trademark or anything on |
@GitMensch @daiyam Ok will do. Also, no it wont conflict, because I made my codium fork install into a different dir, use a different user profile folder, and a different GUID (on windows) to prevent exactly this and so that vscode, vscodium, and codium could all be installed on the same system without interfering with each other. |
I really hope this renaming can happen - it's weird to think that an OSS fork has "Visual Studio" prefixed to its name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love how lightweight webdev has become. The future is bright lol /s.
Closes #193
Additional actions required to merge:
VS*
)Will not be merging until I've confirmed the binaries build and look good on my branch (releases, builds)