-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use new transformation style in delete and paste #835
Conversation
35 failing tests...
I don't really see where diff is used in a lot of cases? is there an obvious base class implementation somewhere I am missing? Trying to understand why this is good :) |
@xconverge the diffs are all used in Essentially now the way we do cursor position updates is by a diff instead of by an exact location. This is because if you're running a command on lots of cursors in multi-cursor mode, previous inserts could offset your current location, which would invalidate locations you calculated. |
Refactoring this massive codebase into this new style is... tough.
The more we do it, though, the more awesome multi-cursor becomes. And also, the more consistent our codebase becomes. Which is nice for anyone who wants to add stuff to it. 😉
Todo