Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scope for vim.autoSwitchInputMethod #8051

Merged
merged 6 commits into from
Dec 28, 2022
Merged

Add scope for vim.autoSwitchInputMethod #8051

merged 6 commits into from
Dec 28, 2022

Conversation

Quanuanc
Copy link
Contributor

What this PR does / why we need it:

  • The im-select path of each machine is different, so it should not be synced.

Which issue(s) this PR fixes

Special notes for your reviewer:

J-Fields
J-Fields approved these changes Dec 28, 2022
View reviewed changes
Copy link
Member

@J-Fields J-Fields left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J-Fields J-Fields merged commit 927ab38 into VSCodeVim:master Dec 28, 2022
@listenerri listenerri mentioned this pull request Jun 23, 2023
Closed
@listenerri listenerri mentioned this pull request Oct 18, 2023
Open
bohrshaw added a commit to bohrshaw/Vim that referenced this pull request Oct 18, 2023
@bohrshaw
Revert "Set scope for vim.autoSwitchInputMethod to machine (VSCod…
fff8e4b 
…eVim#8051)"

This reverts commit 927ab38.

Configuration settings like autoSwitchInputMethod.* shouldn't have a
"machine“ scope as this extension is running on the local machine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-Fields J-Fields J-Fields approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quanuanc @J-Fields