Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remapper fixes #721

Merged
merged 1 commit into from
Sep 6, 2016
Merged

Remapper fixes #721

merged 1 commit into from
Sep 6, 2016

Conversation

jpoon
Copy link
Member

@jpoon jpoon commented Sep 6, 2016 •
edited
Loading

johnfn
johnfn reviewed Sep 6, 2016
View reviewed changes
src/actions/notation.ts
'delete': 'Del',
};

public static Translate(key: string): string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you call this something like normalize?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also does this normalize eg esc to Esc and ESC to Esc?

Copy link
Member Author

@jpoon jpoon Sep 6, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done and added tests to verify.

Esc, ESC, esc, <EsC>, esCape => <Esc>

@johnfn
Copy link
Member

johnfn commented Sep 6, 2016

Check my 2 comments but LGTM otherwise if it fixes the jj problem.

@johnfn
Copy link
Member

johnfn commented Sep 6, 2016

Why is xconverge's commit showing up in the list of commits?

@jpoon jpoon force-pushed the remapper_fixes branch 3 times, most recently from 206122b to 9e879dc Compare September 6, 2016 17:13
@jpoon jpoon mentioned this pull request Sep 6, 2016
Closed
@jpoon jpoon merged commit 9efc43a into master Sep 6, 2016
@jpoon jpoon deleted the remapper_fixes branch September 6, 2016 18:26
@jpoon
Copy link
Member Author

jpoon commented Sep 6, 2016

@johnfn hmm, GitHub doesn't seem to display the merges very well. In any case, I burned the old branch. All is well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpoon @johnfn