Set correct cursor and selection after code format. #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -610,6 +610,18 @@ class CommandFormatCode extends BaseCommand { | |||
|
|
|||
| public async exec(position: Position, vimState: VimState): Promise<VimState> { | |||
| await vscode.commands.executeCommand("editor.action.format"); | |||
|
|
|||
| let selection = vscode.window.activeTextEditor.selection; | |||
There was a problem hiding this comment.
Is there a reason you aren't using vimState.cursorPosition and cursorStartPosition?
rebornix
force-pushed
the
FormatWithCorrectCursor
branch
from
f3c1ad0 to
1443142
Compare
|
Give it a quick turnaound and understand vimState cursor stuff more. |
|
Thanks! this issue has been bugging me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yay! We love PRs! 🎊
Please include a description of your change & check your PR against this list, thanks:
gulp tslint)After code format, the cursor should be set to the first character of the first line of original selection.