-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change debug configurations to loggingLevelForConsole, loggingLevelForAlert #3325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Travis tests have failedHey @jpoon, Node.js: 8npm run forceprettier
if [[ $(git diff-index HEAD -- *.js *.ts *.md) ]]; then git diff; echo "Prettier Failed. Run `gulp forceprettier` and commit changes to resolve."; exit 1; fi
TravisBuddy Request Identifier: b60488b0-10bb-11e9-9565-515aaf612bbe |
jpoon
force-pushed
the
alert
branch
4 times, most recently
from
January 5, 2019 08:07
fcac470
to
432d49a
Compare
loggingLevelForAlert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
refactored the
vim.debug
settings to:vim.debug.loggingLevel
has been renamed tovim.debug.LoggingLevelForConsole
(ie. this is a breaking change). If users do not upgrade to the new config setting, the only adverse effect is that their logs aren't printed to console (ie. low severity).This change also deletes
Message
helper class aroundvscode.window.showError/WarningMessage
, and removes a couple of spots where we would be displaying two errors for the same message.Which issue(s) this PR fixes
Special notes for your reviewer: