Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to use native vscode clipboard #3261

Merged
merged 6 commits into from
Dec 17, 2018
Merged

Change to use native vscode clipboard #3261

merged 6 commits into from
Dec 17, 2018

Conversation

xconverge
Copy link
Member

No description provided.

@xconverge
Copy link
Member Author

fixes #1812

@jpoon
Copy link
Member

jpoon commented Dec 13, 2018

Sweet. Can we also get rid of overrideCopy?

Edit: maybe not, we have a bunch of special logic there --

class CommandOverrideCopy extends BaseCommand {

@jpoon jpoon self-requested a review December 13, 2018 04:40
package.json Show resolved Hide resolved
src/util/clipboard.ts Outdated Show resolved Hide resolved
@xconverge
Copy link
Member Author

Sweet. Can we also get rid of overrideCopy?

Edit: maybe not, we have a bunch of special logic there --

Vim/src/actions/commands/actions.ts

Line 992 in 0151438
class CommandOverrideCopy extends BaseCommand {

Yea it that functionality is really for a different purpose unfortunately

src/util/clipboard.ts Outdated Show resolved Hide resolved
@xconverge
Copy link
Member Author

xconverge commented Dec 16, 2018

Tested on Win10 and Ubuntu, paste performance seems much better

@xconverge xconverge merged commit 16f456c into VSCodeVim:master Dec 17, 2018
@xconverge xconverge mentioned this pull request Dec 17, 2018
@jpoon
Copy link
Member

jpoon commented Dec 17, 2018

Cutting a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants