-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes #2606 #2790
fixes #2606 #2790
Conversation
Travis tests have failedHey @xconverge, Node.js: 8npm test --silent
|
Ah shucks this falls apart near the top of the file since I can't get the full selection length, and prevSelection is already updated by this point. I need to take another approach at this |
Travis tests have failedHey @xconverge, Node.js: 8npm test --silent
|
… use in replay if desired
Travis tests have failedHey @xconverge, Node.js: 8npm test --silent
|
This is pretty wacky...but it is already special cased so 😢
It is only a problem if your selection is from bottom up