Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoToDefinition make invalid history when use C# extension #3865

Closed
yaegaki opened this issue Jul 4, 2019 · 1 comment
Closed

GoToDefinition make invalid history when use C# extension #3865

yaegaki opened this issue Jul 4, 2019 · 1 comment
Labels
kind/bug

Comments

@yaegaki
Copy link
Contributor

yaegaki commented Jul 4, 2019

Describe the bug
GoToDefinition make invalid history when use C# extension.

To Reproduce
Steps to reproduce the behavior:

  1. Install C# extension
  2. Open C# project
  3. Move cursor to a symbol
  4. Type gd

Expected behavior
Make history correctly.

Screenshots
GIF

This gif is run undo command after goToDefinition command.

Environment (please complete the following information):

  • Extension Version: 1.8.1
  • OS Version: Windows_NT x64 10.0.17134
  • VSCode version: 1.36.0
yaegaki added a commit to yaegaki/Vim that referenced this issue Jul 4, 2019
@yaegaki
Assign activeTextEditor to local variable first.
0b97d09 
because activeTexteditor may have changed after call async method.
fixes VSCodeVim#3865
@yaegaki yaegaki mentioned this issue Jul 4, 2019
Merged
@jpoon jpoon closed this as completed in 468a49b Jul 8, 2019
@jpoon jpoon added the kind/bug label Jul 8, 2019
@xconverge
Copy link
Member

I just wanted to comment and thank you for your report, investigation, and then fix. This was a nasty one and it is much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpoon @xconverge @yaegaki