Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancelling a search should not undo :noh #3748

Closed
J-Fields opened this issue May 10, 2019 · 0 comments · Fixed by #3749
Closed

Cancelling a search should not undo :noh #3748

J-Fields opened this issue May 10, 2019 · 0 comments · Fixed by #3749
Labels
kind/bug

Comments

@J-Fields
Copy link
Member

Describe the bug
Cancelling a search with <esc>, <C-c>, etc., will cause the last search to be highlighted if hlsearch is set.

To Reproduce
Steps to reproduce the behavior:

  1. With hlsearch set, search with /xyz.
  2. Run :noh
  3. Start and cancel a search with /<esc>
  4. Observe instances of xyz are highlighted

Expected behavior
:noh still applies; nothing is highlighted until a new search is initiated

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.7.1
  • VSCode version: 1.33.1
  • OS: Windows 10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make sure :noh disables hlsearch until the next search is done
2 participants
@jpoon @J-Fields