Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor.wordSeparators setting is ignored #3166

Closed
alzedd opened this issue Oct 26, 2018 · 2 comments
Closed

editor.wordSeparators setting is ignored #3166

alzedd opened this issue Oct 26, 2018 · 2 comments

Comments

@alzedd
Copy link

alzedd commented Oct 26, 2018

I use to consider this_example two words, because a word separator for me is the underscore.
Tried to change editor.wordSeparators but it was completely ignored, since I found later that there is another setting vim.iskeyword that does basically the same.

Is there a way to add a setting to use the default editor.wordSeparators instead a duplicate setting?

@alzedd alzedd changed the title Word separators settings is ignored editor.wordSeparators setting is ignored Oct 29, 2018
@jpoon
Copy link
Member

jpoon commented Dec 30, 2018

History Lesson: We had vim.iskeyword before editor.wordSeparator was introduced.

Although our ROADMAP (https://github.com/VSCodeVim/Vim/blob/master/ROADMAP.md#options), states:

iskeyword (isk) @,48-57,_,128-167,224-235 keywords contain alphanumeric characters and '_'. If there is no user setting for iskeyword, we use editor.wordSeparators properties.

That seems completely false looking at the code. Don't see anywhere where we are looking at the editor.wordSeparator config.

@jpoon jpoon closed this as completed in 18abd53 Dec 30, 2018
jpoon added a commit that referenced this issue Dec 30, 2018
fix: sync editor.wordSeparators and vim.iskeyword. closes #3166
@pkrefta
Copy link

pkrefta commented Jan 4, 2019

Thanks for your work @jpoon 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants