Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exiting CommandMode should mimic Vim behavior #3035

Closed
mxlian opened this issue Sep 10, 2018 · 0 comments · Fixed by #3036
Closed

Exiting CommandMode should mimic Vim behavior #3035

mxlian opened this issue Sep 10, 2018 · 0 comments · Fixed by #3036
Labels
kind/bug

Comments

@mxlian
Copy link
Contributor

mxlian commented Sep 10, 2018 •
edited
Loading

When in Command Mode (:) you can exit to Normal mode with <Esc> & <C-[> wich are identical. Also <C-c> (which is conceptually different) aborts Command Mode and takes you to Normal Mode.
This exit key bindings are out-of-the-box in vim.

Proposed Solution:
As discussed in the slack channel with @shawnaxsom we need to add <C-c> and <C-[> to actions.ts, as alternatives to exit Command Mode
mxlian added a commit to mxlian/Vim that referenced this issue Sep 10, 2018
@mxlian
Exiting CommandMode as in Vim
e1f5ddb 
This fixes VSCodeVim#3035, adding the missing key bindings to exit CommandMode:
* <C-[>  which is the same as <Esc>
* <C-c>
@mxlian mxlian mentioned this issue Sep 10, 2018
Merged
jpoon added a commit that referenced this issue Sep 21, 2018
@jpoon
Merge pull request #3036 from mxlian/patch-1
bbaf9bc 
Fix: Missing bindings to exit CommandMode. closes #3035
@jpoon jpoon added the kind/bug label Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Missing bindings to exit CommandMode. closes #3035 mxlian/Vim
2 participants
@jpoon @mxlian