Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keymapping bindings inconsistently cased #3012

Closed
sydney-whittington opened this issue Aug 30, 2018 · 2 comments
Closed

Keymapping bindings inconsistently cased #3012

sydney-whittington opened this issue Aug 30, 2018 · 2 comments

Comments

@sydney-whittington
Copy link

Describe the bug
Some keymapping bindings are lowercase, which means remapping them requires trying both cases (Vim default is uppercase) to see what works (or checking the logs). The ones I saw were <home>, <insert> and <end> but I didn't exhaustively search.

To Reproduce

  1. Turn on debug logging (vim.debug.loggingLevel).
  2. Observe mode handler debug messages when pressing:
    a. Home and End
    b. Escape and Delete

Expected behavior
Messages containing:
a. <Home> and <End> (the logs yield <home> and <end>)
b. <Esc> and <Del> (these show as expected)

Environment

VS Code version: Code 1.26.1 (493869ee8e8a846b0855873886fc79d480d342de, 2018-08-16T18:38:57.434Z)
OS version: Windows_NT x64 10.0.14393
vim|vsc|0.16.2

@jpoon
Copy link
Member

jpoon commented Dec 30, 2018

Pretty easy if somebody wants to tackle this. The logic is all here: https://github.com/VSCodeVim/Vim/blob/master/src/configuration/notation.ts#L31

@jpoon jpoon closed this as completed Dec 30, 2018
@jpoon jpoon reopened this Dec 30, 2018
@jpoon jpoon added the kind/bug label Dec 30, 2018
jpoon pushed a commit that referenced this issue May 6, 2019
* Add keybinding regex for normalizing

* Replace changed inputs with capitalized equivalents
@bionboy
Copy link

bionboy commented Jul 31, 2019

Should this be closed? @jpoon

@jpoon jpoon closed this as completed Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants