Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:tablast broken with vscode 1.25.0 #2813

Closed
xconverge opened this issue Jul 6, 2018 · 3 comments · Fixed by #2926
Closed

:tablast broken with vscode 1.25.0 #2813

xconverge opened this issue Jul 6, 2018 · 3 comments · Fixed by #2926

Comments

@xconverge
Copy link
Member

xconverge commented Jul 6, 2018

Vscode 1.25 removed the command workbench.action.openLastEditorInGroup

https://code.visualstudio.com/updates/v1_25#_removed-commands

We utilize this for :tablast

Replace with workbench.action.lastEditorInGroup and mark 1.25 as the minimum vscode version in package.json

@Roshanjossey
Copy link
Contributor

Hi @xconverge, I'm taking a stab at this issue.

Should I commit changes in package-lock.json?

Thank you.

@jpoon
Copy link
Member

jpoon commented Jul 31, 2018

Yes. If you made changes to package.Json, please commit changes to the lock file

@Roshanjossey
Copy link
Contributor

@jpoon, thank you for your response.

Yes, I've made changes to package.json. There are other changes in dependency versions in package-lock.json.

I'll submit a pull request with my changes and let's discuss if we need to make anymore changes to that 😄.

jpoon added a commit that referenced this issue Aug 1, 2018
Fix :tablast breaking in vscode 1.25 #2813
@jpoon jpoon added the kind/bug label Aug 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants