Allow for capacities to be determined post init. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #55 +/- ##
=======================================
- Coverage 80.2% 80.1% -0.1%
=======================================
Files 28 28
Lines 1304 1315 +11
Branches 17 17
=======================================
+ Hits 1046 1054 +8
- Misses 249 252 +3
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more. |
jcoupey
reviewed
Apr 25, 2022
Instead of pre-declaring amount_capacity in init, allow it to be None, and instead verify it after it when the vehicles come in.
Co-authored-by: Julien Coupey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of pre-declaring amount_capacity in init, allow it to be None, and instead verify it after it when the vehicles come in.