Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy 1.6.0に更新 #767

Merged
merged 2 commits into from
Oct 17, 2023
Merged

mypy 1.6.0に更新 #767

merged 2 commits into from
Oct 17, 2023

Conversation

aoirint
Copy link
Member

@aoirint aoirint commented Oct 17, 2023

内容

上のPRにより、mypy 0.991による型チェック時に非対応の構文に遭遇して以下のようなエラーが出て、型チェックが中断されるようになります。

***\Lib\site-packages\fastapi\openapi\models.py:281: error: INTERNAL ERROR -- Please try using mypy master on GitHub:
https://mypy.readthedocs.io/en/stable/common_issues.html#using-a-development-mypy-build
If this issue continues with mypy master, please report a bug at https://github.com/python/mypy/issues
version: 0.991
***\Lib\site-packages\fastapi\openapi\models.py:281: : note: please use --show-traceback to print a traceback when reporting a bug

このPRでは、mypyを最新のmypy 1.6.0に更新します。上のエラーが解消されます。

mypyは、mypy 0.991 (2022-11-08)の次にmypy 1.0 (2023-02-06)がリリースされ、新しいバージョン付けのルールが設定されました(詳細を確認したい場合、mypy 1.0のリリースノートを参照)。以前のバージョニングルールは、mypy 0.470 (2017-01-13)から、PyPI上のパッケージ名mypyの取得に伴う干渉回避のために導入されていたようです。

他のlintライブラリに合わせて、バージョン制約の記号を~から^に変更しました(poetry updateでパッチバージョンのみ更新から、マイナーバージョンを更新するように変更。Poetryのバージョン制約記法ドキュメント)。

このPR後にpoetry updateを実行した場合、mypy >=1.6.0, <2.0.0の範囲で更新されます(^1.x.yと記述した場合の仕様。Poetryのバージョン制約記法ドキュメント)。

関連 Issue

スクリーンショット・動画など

その他

@aoirint aoirint requested a review from a team as a code owner October 17, 2023 08:18
@aoirint aoirint requested review from Hiroshiba and removed request for a team October 17, 2023 08:18
@github-actions
Copy link

Coverage Result

Resultを開く
Name Stmts Miss Cover
run.py 453 305 coverage-33%
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/cancellable_engine.py 91 71 coverage-22%
voicevox_engine/dev/core/init.py 2 0 coverage-100%
voicevox_engine/dev/core/mock.py 27 12 coverage-56%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/downloadable_library.py 93 5 coverage-95%
voicevox_engine/engine_manifest/EngineManifest.py 34 0 coverage-100%
voicevox_engine/engine_manifest/EngineManifestLoader.py 12 0 coverage-100%
voicevox_engine/engine_manifest/init.py 3 0 coverage-100%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/metas/Metas.py 33 0 coverage-100%
voicevox_engine/metas/MetasStore.py 29 12 coverage-59%
voicevox_engine/metas/init.py 2 0 coverage-100%
voicevox_engine/model.py 160 9 coverage-94%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/morphing.py 70 46 coverage-34%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetError.py 2 0 coverage-100%
voicevox_engine/preset/PresetManager.py 81 2 coverage-98%
voicevox_engine/preset/init.py 4 0 coverage-100%
voicevox_engine/setting/Setting.py 11 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 19 0 coverage-100%
voicevox_engine/setting/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 201 146 coverage-27%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 59 30 coverage-49%
voicevox_engine/synthesis_engine/synthesis_engine.py 130 11 coverage-92%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 67 9 coverage-87%
voicevox_engine/user_dict.py 144 11 coverage-92%
voicevox_engine/utility/init.py 5 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 8 1 coverage-88%
voicevox_engine/utility/mutex_utility.py 10 0 coverage-100%
voicevox_engine/utility/path_utility.py 26 8 coverage-69%
TOTAL 2204 684 coverage-69%

@aoirint aoirint mentioned this pull request Oct 17, 2023
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

詳細もありがとうございます、とても助かっています!
じゃんじゃん更新していきたいですね!!

@Hiroshiba Hiroshiba merged commit 48922e6 into VOICEVOX:master Oct 17, 2023
3 checks passed
@aoirint aoirint deleted the patch-mypy-1.6 branch October 17, 2023 08:45
takana-v pushed a commit to voicevox-bridge/bridge-plugin that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants