Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: PyInstallerのバージョンを5.7.0未満に戻す #661

Merged
merged 4 commits into from
Apr 15, 2023

Conversation

sabonerune
Copy link
Contributor

内容

PyInstallerの更新によってWIndowsで行っているPyInstallerのカスタムビルドが失敗するようになってしまいました。
原因が特定できないためとりあえずビルドが通る5.6.2までバージョンを戻します。

関連 Issue

@sabonerune sabonerune requested a review from a team as a code owner April 10, 2023 15:23
@sabonerune sabonerune requested review from y-chan and removed request for a team April 10, 2023 15:23
@github-actions
Copy link

github-actions bot commented Apr 10, 2023

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/metas/Metas.py 33 0 coverage-100%
voicevox_engine/metas/MetasStore.py 29 14 coverage-52%
voicevox_engine/metas/init.py 2 0 coverage-100%
voicevox_engine/model.py 150 9 coverage-94%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetError.py 2 0 coverage-100%
voicevox_engine/preset/PresetManager.py 81 2 coverage-98%
voicevox_engine/preset/init.py 4 0 coverage-100%
voicevox_engine/setting/Setting.py 11 0 coverage-100%
voicevox_engine/setting/SettingLoader.py 19 0 coverage-100%
voicevox_engine/setting/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 201 159 coverage-21%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 57 49 coverage-14%
voicevox_engine/synthesis_engine/synthesis_engine.py 130 11 coverage-92%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 67 9 coverage-87%
voicevox_engine/user_dict.py 144 11 coverage-92%
voicevox_engine/utility/init.py 5 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/core_version_utility.py 8 1 coverage-88%
voicevox_engine/utility/mutex_utility.py 10 0 coverage-100%
voicevox_engine/utility/path_utility.py 26 8 coverage-69%
TOTAL 1407 279 coverage-80%

@sabonerune
Copy link
Contributor Author

(cd "$tempdir/bootloader" && python ./waf all)

(cd "$tempdir/bootloader" && python ./waf all --msvc_targets=x64)

でも対応可能みたいです。

@aoirint aoirint mentioned this pull request Apr 15, 2023
3 tasks
poetry.lock Outdated Show resolved Hide resolved
@sabonerune
Copy link
Contributor Author

コンフリクト解消しました。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

原因メモ。

なんかMSVCのシェル上でビルドすると検出に失敗するみたいです
今までは偶然うまくいっていたけれどWindowsのarm対応が入って壊れたらしいです

@y-chan やろうとしているタスクでビルドがこけちゃうのが障壁になっちゃってる関係でレビュー横取りしちゃいます、すみません!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants