Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

モーフィングの許可に関する設定およびAPIを追加 #578

Merged
merged 10 commits into from
Jan 19, 2023

Conversation

Segu-g
Copy link
Member

@Segu-g Segu-g commented Jan 18, 2023

内容

metasのspeakersupportedFeaturesプロパティをオプショナルで追加しています。

SpeakerSupportedFeaturessynthesisMorphingプロパティの値としてPREMIT | SELF_MORPHING_ONLY | PROHIBITを設定することで、それぞれのSpeakerに対してモーフィングの可否を設定できます。
プロパティが存在しない場合はPREMITと等価です。

関連 Issue

close #577

スクリーンショット・動画など

その他

@Segu-g Segu-g requested a review from a team as a code owner January 18, 2023 11:17
@Segu-g Segu-g requested review from y-chan and removed request for a team January 18, 2023 11:17
@Segu-g Segu-g changed the title add is_synthesis_morphing_permitted cond モーフィングの許可に関する設定およびAPIを追加 Jan 18, 2023
@github-actions
Copy link

github-actions bot commented Jan 18, 2023

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/model.py 169 9 coverage-95%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 206 166 coverage-19%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 57 49 coverage-14%
voicevox_engine/synthesis_engine/synthesis_engine.py 130 11 coverage-92%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 67 9 coverage-87%
voicevox_engine/user_dict.py 129 6 coverage-95%
voicevox_engine/utility/init.py 3 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/path_utility.py 26 6 coverage-77%
TOTAL 1249 263 coverage-79%

@Segu-g Segu-g force-pushed the feature/morphing_permission branch from efdec12 to fd6228c Compare January 18, 2023 12:02
voicevox_engine/model.py Outdated Show resolved Hide resolved
run.py Outdated Show resolved Hide resolved
voicevox_engine/model.py Outdated Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRありがとうございます!!!
ちょっとデータの出どころだけ修正お願いできるとという感じです・・・!

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

早急で正確なコード、ありがとうございました!!!助かります!!!

@Hiroshiba
Copy link
Member

問題ないと思うのでマージします!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

キャラクターごとにモーフィングの可否を設定可能にする
3 participants