Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH:ユーザー辞書のディレクトリを製品版と開発版で切り替える #474

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

sabonerune
Copy link
Contributor

内容

ユーザー辞書のディレクトリを製品版と開発版で切り替えるget_save_dir()の戻り値を製品版と開発版で切り替えるようにします。

関連 Issue

ref #472

その他

  • 追加したis_development()関数の内容がengine_root()とほぼ同じですがこれでいいのか
  • FIXMEの部分をどうするか
    とりあえずVOICEVOX/voicevox-engine[-dev]を返すコードも書いてみましたが…

@github-actions
Copy link

github-actions bot commented Sep 16, 2022

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/model.py 154 7 coverage-95%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 206 166 coverage-19%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 57 49 coverage-14%
voicevox_engine/synthesis_engine/synthesis_engine.py 133 12 coverage-91%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 67 9 coverage-87%
voicevox_engine/user_dict.py 134 12 coverage-91%
voicevox_engine/utility/init.py 3 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
voicevox_engine/utility/path_utility.py 26 6 coverage-77%
TOTAL 1240 271 coverage-78%

@Hiroshiba
Copy link
Member

PRありがとうございます!!

追加したis_development()関数の内容がengine_root()とほぼ同じですがこれでいいのか

大丈夫だと思います!
あ、engine_root()側でもis_development関数を使うよう変えると共通化できて更に良いと思います!

FIXMEの部分をどうするか

すみません、こっちは設計をどうするかレベルの決めが必要なので、保留でお願いします 🙇
議論ができるようissueを建ててみました!

@sabonerune
Copy link
Contributor Author

engine_root()is_development()を使うように変更しました。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! ありがとうございます!

@takana-v さんよかったら確認頂けると・・・!

@takana-v takana-v self-requested a review September 20, 2022 08:54
Copy link
Member

@takana-v takana-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@takana-v takana-v merged commit 65bc9f0 into VOICEVOX:master Sep 20, 2022
@sabonerune sabonerune deleted the userdictdir branch September 20, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

開発版と製品版でユーザー辞書のディレクトリを変更できるようにする
3 participants