-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH:ユーザー辞書のディレクトリを製品版と開発版で切り替える #474
Conversation
PRありがとうございます!!
大丈夫だと思います!
すみません、こっちは設計をどうするかレベルの決めが必要なので、保留でお願いします 🙇 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! ありがとうございます!
@takana-v さんよかったら確認頂けると・・・!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
内容
ユーザー辞書のディレクトリを製品版と開発版で切り替える
get_save_dir()
の戻り値を製品版と開発版で切り替えるようにします。関連 Issue
ref #472
その他
is_development()
関数の内容がengine_root()
とほぼ同じですがこれでいいのかとりあえず
VOICEVOX/voicevox-engine[-dev]
を返すコードも書いてみましたが…