Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

コアのキャッシュkeyを修正 #407

Merged
merged 1 commit into from
May 15, 2022
Merged

コアのキャッシュkeyを修正 #407

merged 1 commit into from
May 15, 2022

Conversation

Hiroshiba
Copy link
Member

内容

の解決です。

関連 Issue

close #406

その他

他にcacheしてそうなところを全部見てみましたが、他は問題ない気がしました。
ついでに、pipは公式でキャッシュ機構があるのでそちらに移行してみました。

@Hiroshiba Hiroshiba marked this pull request as ready for review May 15, 2022 10:55
@Hiroshiba
Copy link
Member Author

@github-actions
Copy link

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 40 4 coverage-90%
voicevox_engine/experimental/init.py 0 0 coverage-100%
voicevox_engine/experimental/guided_extractor.py 128 94 coverage-27%
voicevox_engine/experimental/julius4seg/init.py 0 0 coverage-100%
voicevox_engine/experimental/julius4seg/converter.py 298 295 coverage-1%
voicevox_engine/experimental/julius4seg/sp_inserter.py 116 89 coverage-23%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/model.py 147 7 coverage-95%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 182 145 coverage-20%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 52 43 coverage-17%
voicevox_engine/synthesis_engine/synthesis_engine.py 181 69 coverage-62%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 68 9 coverage-87%
voicevox_engine/user_dict.py 107 10 coverage-91%
voicevox_engine/utility/init.py 3 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
voicevox_engine/utility/engine_root.py 9 2 coverage-78%
TOTAL 1755 775 coverage-56%

@PickledChair
Copy link
Member

ついでに、pipは公式でキャッシュ機構があるのでそちらに移行してみました。

本当ですね! (https://github.blog/changelog/2021-11-23-github-actions-setup-python-now-supports-dependency-caching/ に書いてありました) 。情報ありがとうございます。

@Hiroshiba
Copy link
Member Author

ビルドとそのあとのテスト、通ってそうでした。

Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ちょっと気掛かりなことがあったのでコメントしました。
すみません、よく考えたら大丈夫そうでした……!

.github/workflows/build.yml Show resolved Hide resolved
Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hiroshiba Hiroshiba merged commit d6c18ba into VOICEVOX:master May 15, 2022
@Hiroshiba Hiroshiba deleted the コアのキャッシュkeyを修正 branch May 15, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coreの0.12.0-preview.3を使ったエンジンがwindowsで起動しない
2 participants