Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: pyopenjtalkのバージョンが巻き戻っているのを修正 #356

Merged

Conversation

aoirint
Copy link
Member

@aoirint aoirint commented Mar 2, 2022

内容

PRのマージの順番(文中疑問符の挙動修正 #318 #319 → ユーザ辞書機能 #301 )によって、pyopenjtalkのバージョン(OpenJTalkのバージョンを1.11に更新した変更)が巻き戻ってしまったようです。

VOICEVOX 0.11.3で #318 が再発するようになった(0.10.4では修正されていた)ため、Hotfixを作成しました。

関連 Issue

スクリーンショット・動画など

その他

@github-actions
Copy link

github-actions bot commented Mar 2, 2022

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/model.py 122 7 coverage-94%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 156 126 coverage-19%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 52 43 coverage-17%
voicevox_engine/synthesis_engine/synthesis_engine.py 108 2 coverage-98%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 62 7 coverage-89%
voicevox_engine/user_dict.py 78 8 coverage-90%
voicevox_engine/utility/init.py 3 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
voicevox_engine/utility/engine_root.py 9 2 coverage-78%
TOTAL 1045 205 coverage-80%

@y-chan y-chan requested a review from takana-v March 2, 2022 15:27
Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

Copy link
Member

@takana-v takana-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
修正ありがとうございます!

@takana-v takana-v merged commit 84248ac into VOICEVOX:release-0.11 Mar 2, 2022
takana-v pushed a commit to takana-v/voicevox_engine that referenced this pull request Mar 7, 2022
Hiroshiba pushed a commit that referenced this pull request Mar 7, 2022
Hiroshiba added a commit that referenced this pull request Mar 23, 2022
* To 0.11.0 (#346)

* ドキュメントの更新

* a

* a

* to 0.11.0

* To 0.11.1 (#350)

* release-testのcallのバージョン指定の修正 (#347)

* release-testのcallのバージョン指定の修正

* 時間を伸ばした

* ユーザー辞書についての文をreadmeに追加 (#348)

* ユーザ辞書機能について文章を追加

* 見出しを修正

* 改行を追加

* envの代わりにgithubコンテキストを使うよう変更 (#349)

called workflow では caller workflow で定義された env コンテキストの
変数が使えないらしい
cf. https://docs.github.com/ja/actions/using-workflows/reusing-workflows#limitations

* VOICEVOX_CORE_VERSION 0.11.1

Co-authored-by: takana-v <[email protected]>
Co-authored-by: Gray Suitcase <[email protected]>

* [HOTFIX]捨て仮名の連続を一部許容 (#352)

* Hotfix: pyopenjtalkのバージョンが巻き戻っているのを修正 (#356)

* 「九州」と「そら」を辞書に追加 (#370)

* to 0.11.4 (#371)

* 九州の名を姓に (#372)

* 「九州」の辞書情報を修正 (#373)

Co-authored-by: Hiroshiba <[email protected]>
Co-authored-by: Gray Suitcase <[email protected]>
Co-authored-by: Yuto Ashida <[email protected]>
Co-authored-by: aoirint <[email protected]>
@aoirint aoirint deleted the patch-hotfix-openjtalk-reupgrade branch October 9, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants