-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix: pyopenjtalkのバージョンが巻き戻っているのを修正 #356
Merged
takana-v
merged 1 commit into
VOICEVOX:release-0.11
from
aoirint:patch-hotfix-openjtalk-reupgrade
Mar 2, 2022
Merged
Hotfix: pyopenjtalkのバージョンが巻き戻っているのを修正 #356
takana-v
merged 1 commit into
VOICEVOX:release-0.11
from
aoirint:patch-hotfix-openjtalk-reupgrade
Mar 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-chan
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMです!
takana-v
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
修正ありがとうございます!
takana-v
pushed a commit
to takana-v/voicevox_engine
that referenced
this pull request
Mar 7, 2022
(cherry picked from commit 84248ac)
Merged
Hiroshiba
pushed a commit
that referenced
this pull request
Mar 7, 2022
(cherry picked from commit 84248ac) Co-authored-by: aoirint <[email protected]>
Hiroshiba
added a commit
that referenced
this pull request
Mar 23, 2022
* To 0.11.0 (#346) * ドキュメントの更新 * a * a * to 0.11.0 * To 0.11.1 (#350) * release-testのcallのバージョン指定の修正 (#347) * release-testのcallのバージョン指定の修正 * 時間を伸ばした * ユーザー辞書についての文をreadmeに追加 (#348) * ユーザ辞書機能について文章を追加 * 見出しを修正 * 改行を追加 * envの代わりにgithubコンテキストを使うよう変更 (#349) called workflow では caller workflow で定義された env コンテキストの 変数が使えないらしい cf. https://docs.github.com/ja/actions/using-workflows/reusing-workflows#limitations * VOICEVOX_CORE_VERSION 0.11.1 Co-authored-by: takana-v <[email protected]> Co-authored-by: Gray Suitcase <[email protected]> * [HOTFIX]捨て仮名の連続を一部許容 (#352) * Hotfix: pyopenjtalkのバージョンが巻き戻っているのを修正 (#356) * 「九州」と「そら」を辞書に追加 (#370) * to 0.11.4 (#371) * 九州の名を姓に (#372) * 「九州」の辞書情報を修正 (#373) Co-authored-by: Hiroshiba <[email protected]> Co-authored-by: Gray Suitcase <[email protected]> Co-authored-by: Yuto Ashida <[email protected]> Co-authored-by: aoirint <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
PRのマージの順番(文中疑問符の挙動修正 #318 #319 → ユーザ辞書機能 #301 )によって、pyopenjtalkのバージョン(OpenJTalkのバージョンを1.11に更新した変更)が巻き戻ってしまったようです。
VOICEVOX 0.11.3で #318 が再発するようになった(0.10.4では修正されていた)ため、Hotfixを作成しました。
関連 Issue
スクリーンショット・動画など
その他