Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ユーザー辞書の単語の一覧を返すAPIを追加 #334

Merged
merged 2 commits into from
Feb 20, 2022

Conversation

takana-v
Copy link
Member

内容

ユーザー辞書の単語の一覧を返すAPIを追加します。
/user_dictにGETリクエストを投げることで一覧を取得できるようにします。

関連 Issue

その他

ReturnはDict[int, UserDictWord]となっていますが、実際に返されるjsonのキーは文字列型になります。

@github-actions
Copy link

github-actions bot commented Feb 20, 2022

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/model.py 125 7 coverage-94%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 156 126 coverage-19%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 51 42 coverage-18%
voicevox_engine/synthesis_engine/synthesis_engine.py 108 2 coverage-98%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 62 7 coverage-89%
voicevox_engine/utility/init.py 3 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
voicevox_engine/utility/engine_root.py 9 6 coverage-33%
TOTAL 969 200 coverage-79%

Copy link
Member

@y-chan y-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!

一点だけ、すごく細かな点ですが、気になったのでコメントしてみます。

run.py Outdated Show resolved Hide resolved
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

今回はPR範囲と違うのですが、リリース前にAPI名の調整したいかもと感じたので1つ質問してみました

run.py Show resolved Hide resolved
@Hiroshiba Hiroshiba merged commit 6e2d4f8 into VOICEVOX:master Feb 20, 2022
@takana-v takana-v deleted the add-return-user-dict-endpoint branch February 20, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants