Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setuptoolsをダウングレード #330

Merged
merged 4 commits into from
Feb 18, 2022
Merged

Setuptoolsをダウングレード #330

merged 4 commits into from
Feb 18, 2022

Conversation

Hiroshiba
Copy link
Member

@Hiroshiba Hiroshiba commented Feb 18, 2022

内容

setuptoolsにアップデートが入った関係で、nuitkaビルド後のバイナリが実行できないという問題が発生しました。
Nuitka/Nuitka#1406

nuitkaをアップデートしてもよいのですが、0.10のhotfixを入れる可能性があり、nuitkaのバージョンを上げることは何かしら危険な可能性があるため、一旦setuptoolsをダウングレードすることで解決します。

その他

masterに入れたあと、cherry-pickでrelease-0.10にも適用する予定です。

  • release-0.10にcherry-pick

@github-actions
Copy link

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/full_context_label.py 171 6 coverage-96%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/model.py 75 7 coverage-91%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 164 146 coverage-11%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 52 44 coverage-15%
voicevox_engine/synthesis_engine/synthesis_engine.py 108 2 coverage-98%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 62 7 coverage-89%
voicevox_engine/utility/init.py 2 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
TOTAL 927 219 coverage-76%

Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hiroshiba
Copy link
Member Author

そんな難しくなさそうなのでマージしちゃいます!

@Hiroshiba Hiroshiba merged commit ca48f2f into VOICEVOX:master Feb 18, 2022
@Hiroshiba Hiroshiba deleted the setuptoolsをダウングレード branch February 18, 2022 17:09
@Hiroshiba
Copy link
Member Author

ビルドし直してみた感じ、起動しました・・・!
https://github.com/VOICEVOX/voicevox_engine/releases/tag/0.10.4

takana-v added a commit to takana-v/voicevox_engine that referenced this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants