Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

疑問文の仕様変更反映 #272 #273

Merged
merged 4 commits into from
Jan 10, 2022
Merged

疑問文の仕様変更反映 #272 #273

merged 4 commits into from
Jan 10, 2022

Conversation

qwerty2501
Copy link
Contributor

@qwerty2501 qwerty2501 commented Jan 6, 2022 •
edited
Loading

内容

関連 Issue

refs #272 #253
close #255

スクリーンショット・動画など

accent_phraseのis_interrogativeがない状態でrequestしてもエラーにならないことの確認
accent_phrase_add_improve_evidence

その他

@coveralls
Copy link

coveralls commented Jan 6, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1671319529

  • 18 of 18 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 86.633%
Totals Coverage Status
Change from base Build 1656060838: 0.08%
Covered Lines: 687
Relevant Lines: 793
💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jan 6, 2022 •
edited
Loading

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 0 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 85 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 29 0 coverage-100%
voicevox_engine/full_context_label.py 167 5 coverage-97%
voicevox_engine/kana_parser.py 89 1 coverage-99%
voicevox_engine/model.py 71 7 coverage-90%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/forwarder.py 76 66 coverage-13%
voicevox_engine/synthesis_engine/make_synthesis_engine.py 23 18 coverage-22%
voicevox_engine/synthesis_engine/synthesis_engine.py 107 0 coverage-100%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 49 5 coverage-90%
voicevox_engine/utility/init.py 2 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
TOTAL 793 106 coverage-87%

@qwerty2501
疑問文の仕様変更反映 VOICEVOX#272
6f6283a 
- AccentPhraseにis_interrogativeをもたせる
- 疑問符Mora追加を調整前ではなく調整後に行うようにした VOICEVOX#272 (comment)

refs VOICEVOX#272
@qwerty2501 qwerty2501 force-pushed the feature/add_is_interrrogative_to_accent_phrase branch from 7d4eb98 to 6f6283a Compare January 6, 2022 14:58
@qwerty2501 qwerty2501 mentioned this pull request Jan 6, 2022
Closed
@qwerty2501
Copy link
Contributor Author

is_kana時の/accent_phraseが上手く動かなくなるので #255 の修正内容もこっちで行う

@qwerty2501
create_kanaを疑問文に対応 VOICEVOX#253
04eed50 
/accent_phrases時にis_kanaがtrueだとInternal Server
errorが発生するようになったため、 VOICEVOX#255 での修正をこっちに統合した

refs VOICEVOX#253,VOICEVOX#255
@qwerty2501 qwerty2501 marked this pull request as ready for review January 6, 2022 15:42
@qwerty2501 qwerty2501 mentioned this pull request Jan 7, 2022
Closed
@Hiroshiba
Copy link
Member

ディスカッションがあったのですが、 #272 (comment) のとおり結論が出たので、アサインしてみます！

takana-v
takana-v approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@takana-v takana-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

test/test_synthesis_engine_base.py Show resolved Hide resolved
aoirint
aoirint approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@aoirint aoirint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！ コードは問題なさそうでした！

@aoirint aoirint merged commit 5496881 into VOICEVOX:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takana-v takana-v takana-v approved these changes

@aoirint aoirint aoirint approved these changes

@Hiroshiba Hiroshiba Awaiting requested review from Hiroshiba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@qwerty2501 @coveralls @Hiroshiba @aoirint @takana-v