Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: 環境gitignore #271

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented Jan 5, 2022

内容

隔離環境まわりのディレクトリをgitignoreへ追加
fix #269

@coveralls
Copy link

coveralls commented Jan 5, 2022

Pull Request Test Coverage Report for Build 1657202711

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.558%

Totals Coverage Status
Change from base Build 1656060838: 0.0%
Covered Lines: 689
Relevant Lines: 796

💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Jan 5, 2022

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 0 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 85 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 29 0 coverage-100%
voicevox_engine/full_context_label.py 167 5 coverage-97%
voicevox_engine/kana_parser.py 87 1 coverage-99%
voicevox_engine/model.py 70 7 coverage-90%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/forwarder.py 76 66 coverage-13%
voicevox_engine/synthesis_engine/make_synthesis_engine.py 23 18 coverage-22%
voicevox_engine/synthesis_engine/synthesis_engine.py 107 0 coverage-100%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 55 6 coverage-89%
voicevox_engine/utility/init.py 2 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
TOTAL 796 107 coverage-87%

@tarepan tarepan marked this pull request as ready for review January 5, 2022 07:08
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

メンテナンスのこと考えると、↓をコピペ(あとlock系のコメントを外す)が一番丸いのかなーとも思いました。
https://github.com/github/gitignore/blob/main/Python.gitignore

@tarepan
Copy link
Contributor Author

tarepan commented Jan 7, 2022

同意です、最終的にはGitHub公式へ全て寄せるのが丸いと思います.

diffを取ってみたところ、このレポジトリ特有のignore属性等あったので、寄せる前にOKかの検討が必要そうです.
このPRとは分けて扱うのが安全と考えます.
このPRがmergeされたのち、別issueを建てる方針はどうでしょうか?

@Hiroshiba
Copy link
Member

Hiroshiba commented Jan 7, 2022

なるほどです!
その方針で良いと思います、issue作成お願いします!
(これくらいの規模であればいきなりPRとかでも全然大丈夫です!)

@Hiroshiba
Copy link
Member

問題なさそうなのでマージしちゃいます!

@Hiroshiba Hiroshiba merged commit b7269fa into VOICEVOX:master Jan 7, 2022
@tarepan tarepan deleted the feature/env_ignore branch January 7, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

venvフォルダ等をgitignoredする
3 participants