Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-0.10をmasterに反映 #242

Merged
merged 1 commit into from
Dec 20, 2021
Merged

release-0.10をmasterに反映 #242

merged 1 commit into from
Dec 20, 2021

Conversation

Hiroshiba
Copy link
Member

内容

release-0.10ブランチに0.10のプレビュー版を作っていく予定でしたが、プレビュー版は普通にmasterで作ればよい(latest)ということに気づきました。
preview版がブランチで別れていると今みたいにマージミスが発生してしまいそうなので、masterをpre版として運用してみようと思います。

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1600505231

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.428%

Totals Coverage Status
Change from base Build 1599264227: 0.0%
Covered Lines: 675
Relevant Lines: 781

💛 - Coveralls

VERSION.txt Outdated
Comment on lines 0 to 1
0.9.3 No newline at end of file
0.10.preview.2
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VERSION.txtの更新がどうしても変になってしまうので、どうしたものか迷いました・・・
release作るときのtag名でVERSION.txtをリプレイスするのが良いのかなと思いました。

@github-actions
Copy link

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 0 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 85 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 30 1 coverage-97%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 75 1 coverage-99%
voicevox_engine/model.py 70 7 coverage-90%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/forwarder.py 76 66 coverage-13%
voicevox_engine/synthesis_engine/make_synthesis_engine.py 23 18 coverage-22%
voicevox_engine/synthesis_engine/synthesis_engine.py 108 0 coverage-100%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 55 6 coverage-89%
voicevox_engine/utility/init.py 2 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
TOTAL 781 106 coverage-86%

Copy link
Member

@aoirint aoirint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

masterブランチでpreview版を運用してみてよさそうです。
挙動を分ける必要が出ることがあるかもしれませんが、ブランチを分けると #241 (comment) のように通常の管理が大変そうなので、必要になったときに対応するでいいかなと思いました。

Copy link
Member

@takana-v takana-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同じく、masterブランチでpreview版を運用しても良いと思います。

@takana-v takana-v merged commit eac0e18 into master Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants