Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: コアバージョン一覧を core_version_list 変数で管理 #1447

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented Jun 28, 2024

内容

#1391 (comment) に従い、core_version_list でコアバージョン一覧を管理するリファクタリングを提案します。

これにより全 router が CoreManager 非依存になります🎉

関連 Issue

ref #1391 (comment)
resolve #1391 (final step 🎉)

@tarepan tarepan requested a review from a team as a code owner June 28, 2024 06:00
@tarepan tarepan requested review from Hiroshiba and removed request for a team June 28, 2024 06:00
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@Hiroshiba Hiroshiba merged commit f3e449f into VOICEVOX:master Jun 28, 2024
4 checks passed
@tarepan tarepan deleted the refactor/no_core_router branch June 28, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: コアを各機能モジュールに内蔵
2 participants