-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add: .get_engine()
で latest version を取得できるように
#1421
Merged
Hiroshiba
merged 10 commits into
VOICEVOX:master
from
tarepan:refactor/get_engine_latest
Jun 28, 2024
+59
−34
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1ee1127
add: `.get_engine()` に None 入力による latest 取得を追加
tarepan 45dc377
Merge branch 'master' into refactor/get_engine_latest
tarepan 68a4181
Merge branch 'master' into refactor/get_engine_latest
tarepan 5bc60a0
Merge branch 'master' into refactor/get_engine_latest
tarepan dfc4bd0
refactor: Cancellable の version を core_version へ変更して整理
tarepan b84f6df
Merge branch 'master' into refactor/get_engine_latest
tarepan 421d8ab
Merge branch 'master' into refactor/get_engine_latest
tarepan 76b220b
refactor: morphing のコア直接依存を削除
tarepan 3b0428d
refactor: None → LATEST_VERSION の変換を導入
tarepan d2bb45b
refactor: 定数を Final 化
tarepan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!!
has_engine
危ないかも?(LagestVersionが受け付けられない・・・けど型的には大丈夫か。)確認したらここでの利用がなくなって、どうやら
has_engine
がテストからしか使われなくなったっぽみです。一緒に消してしまっても良いかも・・・?
だけどまあこのPRは問題じゃないから大丈夫そう!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
見逃していました、指摘ありがとうございます!
#1446 にて削除します。