FIX: manage_libraryがfalseのときOpenAPIスキーマーの参照がエラーになる問題を修正
#1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Jun 2, 2024
There was a problem hiding this comment.
変更ありがとうございます！！
１点だけコメントしました！
しかしまぁ、FastAPIがopenapiにmodelが追加する・しないのロジックよくわかんないですねぇ。。
manage_library=FalseならBaseLibraryInfoを使うAPIが全部消える気がするので、そもそもBaseLibraryInfoがopenapiに現れないでほしいのですが･･･。
全然関係ないけど、manage_libraryをfalseにした状態でOpenAPI作ってエディタ側に反映させると、manage_libraryがtrueなエンジンのAPIが見えなくなりますね！！
manage_libraryがfalseであってもAPIを消さない形のが良いかもしれない。
Hiroshiba
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
engine_manifest.jsonのmanage_libraryがfalseのときOpenAPIスキーマーからBaseLibraryInfoが参照するLibrarySpeakerが欠落していたためエラーが発生していました。これを修正します。
スクリーンショット・動画など
その他
manage_libraryがfalseのときエディタ側のAPI更新ができなかったので気づきました。