Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: typos 設定を pyproject.toml へ移植 #1367

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 30, 2024

内容

typos 設定を pyproject.toml へ移植しルートの設定ファイルを削除するリファクタリングを提案します。

typos の設定値が正しく機能していることを確認済みです。

関連 Issue

無し

@tarepan tarepan requested a review from a team as a code owner May 30, 2024 15:40
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 30, 2024 15:40
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

READMEの変更も必要かもです!

@tarepan
Copy link
Contributor Author

tarepan commented Jun 2, 2024

READMEの変更も必要

👍️
抜けていました、指摘ありがとうございます!
README.md および CONTRIBUTING.md の typos 設定に関する記述を更新しました。


@Hiroshiba
全指摘箇所の反映・テストパスを確認しました。Re-review よろしくお願いします。

Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hiroshiba Hiroshiba merged commit a7d8c50 into VOICEVOX:master Jun 5, 2024
4 checks passed
@tarepan tarepan deleted the refactor/typos_config_file branch June 5, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants