整理: NumPy 向けスナップショットユーティリティを追加 #1356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hiroshiba |
This was referenced Jun 3, 2024
Co-authored-by: Hiroshiba <[email protected]>
Co-authored-by: Hiroshiba <[email protected]>
|
@Hiroshiba |
Hiroshiba
reviewed
Jun 16, 2024
test/unit/tts_pipeline/__snapshots__/test_tts_engine/test_mocked_synthesize_wave_output.json
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要: NumPy 向けスナップショットユーティリティを追加してリファクタリング
現在の VOICEVOX ENGINE はスナップショットテスト用に様々なユーティリティを用意している。
しかし NumPy 値・配列向けのユーティリティが存在しないため、list 化などのワークアラウンドを用いていた。また長大文字列のハッシュ化に相当する長大配列のハッシュ化が提供されていなかった。
これにより音声合成のスナップショットが巨大になっていた。
このような背景から、NumPy 向けスナップショットユーティリティを追加するリファクタリングを提案します。
関連 Issue
無し