Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: latest version 関連を簡略化 #1311

Closed

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 23, 2024

内容

概要: latest version 関連を簡略化するリファクタリング

CoreManagerTTSEngineManager の実装により、generate_app()latest_core_version 引数が不要になった。
これに伴い、latest_core_version 取得も不要となり、これが更に CoreManagerTTSEngineManager.latest_version() 自体を不要にする。
すなわち、これまでのリファクタリングに基づいて latest version 関連コードの大半を削除可能になった。

このような背景から、latest version 関連を簡略化するリファクタリングを提案します。

関連 Issue

無し

@tarepan tarepan requested a review from a team as a code owner May 23, 2024 08:42
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 23, 2024 08:42
@tarepan tarepan marked this pull request as draft May 24, 2024 02:54
@tarepan
Copy link
Contributor Author

tarepan commented May 24, 2024

#1234 (comment) との兼ね合いで一旦 pending。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant