Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: ビルド CI step を分割 #1294

Merged
merged 1 commit into from
May 24, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 21, 2024

内容

ビルド CI の複雑な step を単純な step の組み合わせへ分割するリファクタリングを提案します。

関連 Issue

無し

@tarepan tarepan requested a review from a team as a code owner May 21, 2024 17:50
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 21, 2024 17:50
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

.github/workflows/build-engine-package.yml Show resolved Hide resolved
@Hiroshiba Hiroshiba merged commit ccfa54f into VOICEVOX:master May 24, 2024
4 checks passed
@Hiroshiba
Copy link
Member

LGTMですが、くっつける・分割するが開発者によって分かれるだろうなとちょっと思いました。
難しいですねぇ・・・。

@tarepan
Copy link
Contributor Author

tarepan commented May 24, 2024

開発者によって分かれる

ひとまず bash 最小化(= run | 解体)の方針でリファクタリングしています。
適切な粒度ポリシーは組織・プロジェクトごとに違うので難しいですねぇ。

@tarepan tarepan deleted the refactor/split_steps branch May 24, 2024 02:23
@Hiroshiba
Copy link
Member

なるほどです。

ちなみに良いビルドスクリプトの手引とかってあるんでしょうか・・・?
ansible辺りにありそうな予感がちょっとします

@tarepan
Copy link
Contributor Author

tarepan commented May 27, 2024

良いビルドスクリプトの手引

寡聞にして知らないです🥺 Site Reliability Engineer な人達が詳しそう。
Dockerfile やTerraform の文脈で色々ありそうな予感があります。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants