追加: ビルド特化 poetry group build を作成
#1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要: ビルド特化 poetry group
buildを新規作成現在のビルドプロセスでは
requirements-dev.txtで依存パッケージをインストールし、PyInstaller でパッケージングしている。#1282 (comment) で指摘された通り、PyInstaller の関係で、インストールされる依存パッケージはプロダクションと限りなく同一であることが望ましい。
requirements-dev.txtはビルドにもプロダクションにも不要な複数のパッケージが含まれており、改善の余地がある。また
-devは一般に開発環境用の名称であり、ビルド特化 group の名前として違和感がある。このような背景から、ビルド特化 poetry group
buildの新規作成を提案します。関連 Issue
part 1 of #1282