修正: safety を dev から test へ移動
#1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要:
safetyをdevからtestへ移動して修正safetyは依存パッケージの安全性テストに用いられている外部パッケージである。テスト用であるため、本来であれば poetry の
group.testにて管理されるべきである。しかし手違いで
group.devで管理されている。これを反映して GitHub Actions の安全性テストでもrequirements-dev.txtが利用されている。これはバグである。このような背景から、
safetyをdevからtestへ移動して修正することを提案します。関連 Issue
ref #1151