Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

整理: engine_manifest_assets/ をリソースディレクトリへ移動 #1247

Merged
merged 2 commits into from
May 20, 2024
Merged

整理: engine_manifest_assets/ をリソースディレクトリへ移動 #1247

merged 2 commits into from
May 20, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 15, 2024

内容

engine_manifest_assets/ をリソースディレクトリへ移動してリファクタリングすることを提案します。

変更後、以下のチェックをおこないました：

  • pyinstaller ビルド → 成功
  • ./dist/run/run 実行 → 成功
  • GET /engine_manifest で term of services を取得 → assets 内の文章が表示

関連 Issue

step2 of #1243

@tarepan tarepan mentioned this pull request May 15, 2024
Closed
5 tasks
@tarepan tarepan changed the title refactor: engine_manifest_assets/ をリソースディレクトリへ移動 整理: engine_manifest_assets/ をリソースディレクトリへ移動 May 15, 2024
@tarepan tarepan marked this pull request as ready for review May 17, 2024 20:09
@tarepan tarepan requested a review from a team as a code owner May 17, 2024 20:09
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 17, 2024 20:09
Hiroshiba
Hiroshiba approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！！

自動ビルドが通れば問題ないはず！！

@Hiroshiba Hiroshiba merged commit 0cfb336 into VOICEVOX:master May 20, 2024
4 checks passed
@tarepan tarepan deleted the refactor/resource_manifest_assets branch May 20, 2024 03:57
@tarepan
Copy link
Contributor Author

tarepan commented May 20, 2024

自動ビルドの通過を確認しました。
https://github.com/VOICEVOX/voicevox_engine/actions/runs/9151829077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarepan @Hiroshiba