Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: UserDictionary メソッドへ関数を移植 #1241

Merged
merged 4 commits into from
May 17, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 14, 2024

内容

UserDictionary メソッドへ関数を移植してリファクタリング

mutex デコレータ周りは動作が不安なため、本 PR では着手しない(辞書周り DI が実現 → API unit test を有効化 → 着手、の予定)

関連 Issue

successor of #1222

@tarepan tarepan requested a review from a team as a code owner May 14, 2024 04:15
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 14, 2024 04:15
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

関数をメソッド化する場合、メソッド化して関数を叩いてから処理を移すよりも、関数を移動してから一気にメソッド化するとレビュー的にはよりやりやすそうでした!(知見)

@Hiroshiba Hiroshiba merged commit 81a9360 into VOICEVOX:master May 17, 2024
3 checks passed
@tarepan tarepan deleted the refactor/user_dict_func_method branch May 17, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants