整理: 204
path operation の Response 明示返り値を削除
#1237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要:
204
path operation の Response 明示返り値を削除してリファクタリングFastAPI の path operation で
204 No Content
を表現する場合、path operation デコレータでstatus_code=204
を指定すれば関数ではreturn
するだけでよい。しかし現在の実装では
Response(status_code=204)
を明示的に返しており、これは二重管理である。二重管理はバグの温床 (ref #1236) である。また path operation 関数の型付けが
Response
となって他 path operations との一貫性を失わせている。このような背景から、
204
path operation の Response 明示返り値を削除してリファクタリングすることを提案します。関連 Issue
無し