整理: EngineManifestLoader を削除して簡略化
#1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
May 17, 2024
Hiroshiba
approved these changes
May 17, 2024
This was referenced May 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要:
EngineManifestLoaderを削除してリファクタリングEngineManifestLoaderはエンジンマニフェストを取得するクラスである。そのインスタンスは生成直後に
.load_manifest()メソッドが呼ばれており、実質的には関数として機能している。ゆえにクラスが過剰なラッパーとなっている。
このような背景から、
EngineManifestLoaderの削除によるリファクタリングを提案します。関連 Issue
無し